perf(cache): fix slice capacity under-allocation in SetUserOnline#3746
Merged
Conversation
buvidk1234
requested review from
FGadvancer,
skiffer-git and
withchao
as code owners
pull-request-size
Bot
added
the
size/XS
withchao
approved these changes
Jun 26, 2026
FGadvancer
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
argvslice was initialized with a capacity of 2, but 4 metadataparameters were immediately appended. This caused an unnecessary
reallocation on every status update.
Corrected the initial capacity to 4 to avoid extra memory allocation
in the high-concurrency online status sync path.